plotter: Adjust min and max plot heights to be a factor of the min and max values #1612
Conversation
There was a problem hiding this comment.
This does make it so constant values get displayed instead of hidden, but there's something wrong with the update range - it's possible to get several consecutive values outside the widget (maybe related to #1561, if the canvasHeight is incorrect or something?), and when there are small changes they're confined to the middle of the widget instead of expanding to fill it:
Screen.Recording.2025-01-27.at.12.09.42.am.mov
Also, the issue you linked to seems to be about video connection logs - I'm not sure this PR fixes that?
rafaellehmkuhl
force-pushed
the
adjust-plotter-min-max
branch
from
de168c6 to
6f91e9e
Compare
|
@ES-Alexander everything is inside the canvas now. |
src/components/widgets/Plotter.vue
Outdated
| maxValue = Math.max(...valuesHistory) | ||
| const maxY = maxValue > 0 ? maxValue * 1.05 : maxValue * 0.95 | ||
| minValue = Math.min(...valuesHistory) | ||
| const minY = minValue > 0 ? minValue * 0.95 : minValue * 1.05 |
There was a problem hiding this comment.
| maxValue = Math.max(...valuesHistory) | |
| const maxY = maxValue > 0 ? maxValue * 1.05 : maxValue * 0.95 | |
| minValue = Math.min(...valuesHistory) | |
| const minY = minValue > 0 ? minValue * 0.95 : minValue * 1.05 | |
| maxValue = Math.max(...valuesHistory) | |
| minValue = Math.min(...valuesHistory) | |
| // Add a buffer to keep the plot neatly within bounds, and centered when there are no changes | |
| const buffer = 0.05 * (maxValue != minValue ? maxValue - minValue : 1) | |
| const maxY = maxValue + buffer | |
| const minY = minValue - buffer |
I figured out why it was squashing small fluctuations! If the buffer is a fixed proportion of the values then if the values are changing by less than that proportion (e.g. due to a relatively large offset) then they end up getting compressed in the plot.
This alternative approach keeps a 5% buffer of the range for normal use-cases, and then treats a flatline of all the same values (i.e. range == 0) as a special case that keeps the line centered.
Maaaaaan I'm testing with a sine wave here and you're absolutely right! Wtaf! Nice catch! |
rafaellehmkuhl
force-pushed
the
adjust-plotter-min-max
branch
from
6f91e9e to
d45ad37
Compare
…d max values This prevents cases where the value is constant and no line appears in the plot, since the current and only value is equal to min and max. Co-authored-by: ES-Alexander <[email protected]>
rafaellehmkuhl
force-pushed
the
adjust-plotter-min-max
branch
from
d45ad37 to
0012c37
Compare
Nice! Made sure to put you as co-author in this one! Thanks for the solution on the centering problem! |
This prevents cases where the value is constant and no line appears in the plot, since the current and only value is equal to min and max, like when monitoring an stable video frame rate.