Streaming repo parsing #1000
Open
Streaming repo parsing #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvolp12
reviewed
Mar 24, 2025
repo/repo.go
Outdated
| @@ -97,6 +107,8 @@ func IngestRepo(ctx context.Context, bs cbor.IpldBlockstore, r io.Reader) (cid.C | |||
| } | |||
| } | |||
|
|
|||
| bufrPool.Put(bufr) | |||
There was a problem hiding this comment.
What happens if the function returns before this line? Do we need to defer putting the buffer back in the pool?
There was a problem hiding this comment.
yeah deferring the put probably makes sense, in general its not a huge deal if we miss putting something back in the pool in an error case, but this isnt inconvenient
whyrusleeping
force-pushed
the
feat/stream-repo-parse
branch
from
bfa8774 to
279d668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at a streaming repo parse utility. This iterates the repo in mst order, waiting for the blocks it needs to be read from the passed in stream.
It currently doesnt have a good backpressure mechanism, will need to add that next. I kinda wanted to get this to be a generator pattern type thing instead of using goroutines, but since the blocks can be reordered it gets sticky... we will see