carstore: don't ignore the first record in sqlite #1103
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameli
force-pushed
the
eli/fix-sqlite-carstore
branch
from
797a573 to
255733a
Compare
|
Force-pushed to ignore the same check in a different spot |
|
@whyrusleeping i'll defer to you on this one |
iameli
force-pushed
the
eli/fix-sqlite-carstore
branch
from
255733a to
07b55db
Compare
|
Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to the SQLite carstore -- the first record in the cache will have ID 0, there's no reason to ignore it. Naturally, this case happens a lot in testing and stuff 'cause the first attempt to get a revision on an empty database will fail