Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Add codecoverage settings with reasonable tolerance #40

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

rosesyrett
Copy link
Collaborator

Relates to bluesky/ophyd#1149

As the repository grows it's going to get more and more annoying seeing CI fail because of a 0.01% patch change.

So this is just to introduce some reasonable tolerances. In ophyd's case it was 0.1%, here it should probably be less (as there are far fewer tests here)

@prjemian
Copy link

Could you force the while clause to be called, only in CI, by adding a slow ophyd.Signal to the area detector? This would stabilize the code coverage.

"slow" would be enabled by subclassing ophyd.Signal and adding time.sleep(self.delay) before returning its value from .get().

@rosesyrett rosesyrett merged commit 51a075a into main Aug 23, 2023
13 checks passed
@rosesyrett rosesyrett deleted the codecov branch August 23, 2023 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants