Skip to content

Movable type referencing is broken in Pydantic 2.11 due to internal changes. #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks
ZohebShaikh opened this issue Apr 8, 2025 · 3 comments · May be fixed by bluesky/scanspec#165
Open
3 tasks

Movable type referencing is broken in Pydantic 2.11 due to internal changes. #908

ZohebShaikh opened this issue Apr 8, 2025 · 3 comments · May be fixed by bluesky/scanspec#165
Labels
bug Something isn't working

Comments

@ZohebShaikh
Copy link
Contributor

ZohebShaikh commented Apr 8, 2025 •
edited
Loading

Types resolve without relying on private Pydantic APIs.

Actual
Resolution fails for motor in spec_scan plan

Steps

  1. Update to pydantic 2.11
  2. Run system test for spec_scan
  3. Error occurs

Acceptance

  • Works with Pydantic 2.11+
  • Uses stable, public APIs
  • Long-term fix

Ref
pydantic/pydantic#11392 (This is making change to schema which is a minor changes but good to know )
@ZohebShaikh ZohebShaikh added the bug Something isn't working label Apr 8, 2025
@tpoliaw
Copy link
Contributor

tpoliaw commented May 27, 2025

I think this is a return of #782 which was caused by bluesky/scanspec#156. I will try and figure out what changed to bring it back.

@tpoliaw
Copy link
Contributor

tpoliaw commented May 27, 2025

Git bisect points to pydantic/pydantic#10863

@tpoliaw tpoliaw linked a pull request May 28, 2025 that will close this issue
Open
1 task
@tpoliaw
Copy link
Contributor

tpoliaw commented May 28, 2025

Fixed in scanspec (pending PR being merged) but will mean we need to update scanspec before we can update pydantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Pydantic 2.11+ in discriminated union decorator bluesky/scanspec
2 participants
@tpoliaw @ZohebShaikh