chore(types): Use common base type for all access policy types #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoliaw
force-pushed
the
common_policy
branch
2 times, most recently
from
80f7d2b to
716b65c
Compare
DiamondJoseph
changed the title
DiamondJoseph
approved these changes
Aug 11, 2025
Contributor
DiamondJoseph
left a comment
DiamondJoseph
left a comment
There was a problem hiding this comment.
@danielballan leaving room for you to disagree if you'd like, but I think unlike #1047 an ABC here is fine?
Member
danielballan
force-pushed
the
common_policy
branch
4 times, most recently
from
ceaa08b to
2e2465a
Compare
danielballan
force-pushed
the
common_policy
branch
from
2e2465a to
b14ce2c
Compare
nmaytan
reviewed
Oct 7, 2025
nmaytan
force-pushed
the
common_policy
branch
from
0e5b08d to
2675418
Compare
nmaytan
approved these changes
Oct 17, 2025
jmaruland
pushed a commit
to jmaruland/tiled
that referenced
this pull request
Oct 22, 2025
…ky#1044) * Use common base type for all access policy types * Type access policy methods, and introduce aliases. * Fix broken import, more typing updates * Use Mapping rather than Dict (deprecated) for AccessBlob type --------- Co-authored-by: Dan Allan <[email protected]> Co-authored-by: nmaytan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep work for #928
Checklist