chore(types): Add typing to Authenticator

[tpoliaw]

Further prep work for #928

[ZohebShaikh]

tiled/tiled/server/settings.py

Line 59 in 59cd577

return Settings()

This is not giving the authentication settings in

tiled/tiled/server/authentication.py

Line 210 in 59cd577

settings: Settings = Depends(get_settings),

Because it is creating a new settings object Will this be addressed in this PR ?

[tpoliaw]

Because it is creating a new settings object Will this be addressed in this PR ?

It should be caching the returned settings instance so later modifications to it should be returned next time? It should be fixed but probably not in this PR. Was it working without this change?

[ZohebShaikh]

Because it is creating a new settings object Will this be addressed in this PR ?

It should be caching the returned settings instance so later modifications to it should be returned next time? It should be fixed but probably not in this PR. Was it working without this change?

It is the same behavior as on main as well , It was more of a feature request to have authentication settings come in settings object

tiled/tiled/server/app.py

Lines 430 to 437 in 59cd577

	for item in [
	"allow_anonymous_access",
	"secret_keys",
	"single_user_api_key",
	"access_token_max_age",
	"refresh_token_max_age",
	"session_max_age",
	]:

In this override settings it never adds the settings for authentication.

[danielballan]

Give us a nudge when this is ready for 🇺🇸 review. :-)

[tpoliaw]

@danielballan I think it's reviewable now I've patched the rebase I mangled.

[danielballan]

I rebased. The file test_access_control.py was effectively rewritten, and it no longer defined a custom Authenticator class. Thus, no changes to that file are necessary.