Skip to content

ENH: configure recycle and pre_ping for storage ADBC connections #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ENH: configure recycle and pre_ping for storage ADBC connections #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e18fb2
ENH: configure recycle and pre_ping for storage ADBC connections
genematx Sep 17, 2025
7e18687
MNT: pin the version of adbc_driver_manager
genematx Sep 17, 2025
0080c21
MNT: changelog
genematx Sep 22, 2025
cb04e4b
MNT: clarify changelog
genematx Sep 24, 2025
17f6793
Merge branch 'main' into fine-tune-pooling
genematx Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ Write the date in place of the "Unreleased" in the case a new version is release

## Unreleased

### Added

- Configured recycle and added explicit pre-ping option (disabled by default) for
storage databases.

### Fixed

- Column names in `TableStructure` are explicitly converted to strings.
Expand Down
8 changes: 6 additions & 2 deletions tiled/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,12 @@ def _connection_pool(self) -> "sqlalchemy.pool.QueuePool":
if (self.dialect == "duckdb") or (":memory:" in self.uri):
pool = sqlalchemy.pool.StaticPool(creator)
else:
pool = sqlalchemy.pool.QueuePool(
creator, pool_size=self.pool_size, max_overflow=self.max_overflow
return sqlalchemy.pool.QueuePool(
creator,
pool_size=self.pool_size,
max_overflow=self.max_overflow,
recycle=1800, # Recycle connections after 30 minutes
pre_ping=False, # Default -- don't test connections before using them
)
monitor_db_pool(pool, self.uri)

Expand Down