-
Notifications
You must be signed in to change notification settings - Fork 63
Fix database settings #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix database settings #1231
Conversation
This reverts commit 9339ab4.
|
Thanks so much @dan-fernandes! This is great, and very appreciated. We observed a related recent regression in #1228. I suspect this will fix that as well. I pushed some additional commits to your PR branch here fixing these failures: I think your last commit, introducing Edit: In fact, I did add a commit to use this "named memory" approach. It's a lighter-touch change than introducing file-based databases, and it may run a little faster on CI, which has very slow disk. |
danielballan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor items
|
I introduced new utility function, It appears to be flaky, involving a race condition because locally it will sometimes pass. |
|
I think those last commits did the trick. My train is almost home, so I'll hand off to 🇬🇧 here. |
|
As mentioned in #1223, I've gone back on caching all in-memory databases, and instead given the authn database a unique in-memory, cached URI. This more closely resembles the expected behaviour of SQLAlchemy and avoids weird workarounds. Also, minor changes. |
Fixes #1223