Use Adapter[Any] as type of root_tree #1232
Open
+84
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoliaw
force-pushed
the
root-tree-type
branch
from
4553c84 to
a50d1cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
root_treeis never going to be an instance ofBaseSettings.I'm not clear on the difference between
AnyAdapterandAdapter[Any]but the
MapAdapterreturned from the config tree merging is not aninstance of
AnyAdapterso I've usedAdapter[Any]for everything fornow.
The
EntryPointStringhas been expanded using the same approach aspydantic's ImportString so that it satisfies the type checker when it's
used in the config loading instead of appearing as a str.