Refactor auth #891
Merged
Refactor auth #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
force-pushed
the
refactor-auth
branch
4 times, most recently
from
3f3b98f to
5dc6dcc
Compare
DiamondJoseph
force-pushed
the
refactor-auth
branch
from
5dc6dcc to
ea78168
Compare
DiamondJoseph
force-pushed
the
refactor-auth
branch
from
3efe269 to
4b9c7a2
Compare
DiamondJoseph
force-pushed
the
refactor-auth
branch
from
4b9c7a2 to
ea3fc60
Compare
Member
danielballan
left a comment
danielballan
left a comment
There was a problem hiding this comment.
First pass. Echoing my comments on Slack, I love this. It's great to have another pair of eyes on this.
2 tasks
danielballan
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to pick apart the changes required before #877 into more managably reviewable commits.
This is a step towards closing #887
Checklist