FIX: purge stale sessions beyond refresh-ability #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add: elevate PURGE_INTERVAL to global scope - change: purge_expired to have dialect dependent behavior - fix: adds unique() to deal with eager loading of joined relationships (Principal/Session)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #922
This extends the
purge_expiredcall to accept an optionalrefresh_token_max_age. ThePURGE_INTERVALwas elevated to the module level to enable testing. Testing exposed some silent issue with the previous purge function that were solved by two changes:.unique()call to the result following the query to handle any eager loading of joined tables.The tests were run first against the original
purge_expiredfunction with these modifications, before updating the function.Since all testing was done locally against SQLite, I expect this will need to be tested against a PostgresSQL auth database before approval and merge (not sure if this is in the CI).
Checklist