rename BufferSize to Size and remove Close method

documentcoder.go

@@ -86,6 +86,10 @@ func (c *chunkedDocumentCoder) flush() error {
 }
 
 func (c *chunkedDocumentCoder) Write() error {
+	// flush first
+	if err := c.flush(); err != nil {
+		return err
+	}
 	var err error
 	var wn, n int
 	// write chunk offsets
@@ -109,12 +113,6 @@ func (c *chunkedDocumentCoder) Write() error {
 	return nil
 }
 
-// Close indicates you are done calling Add() this allows
-// the final chunk to be encoded.
-func (c *chunkedDocumentCoder) Close() error {
-	return c.flush()
-}
-
 func (c *chunkedDocumentCoder) Reset() {
 	c.compressed = c.compressed[:0]
 	c.offsets = c.offsets[:0]
@@ -123,8 +121,8 @@ func (c *chunkedDocumentCoder) Reset() {
 	c.buf.Reset()
 }
 
-// BufferSize returns buffer len
-func (c *chunkedDocumentCoder) BufferSize() uint64 {
+// Size returns buffer size of current chunk
+func (c *chunkedDocumentCoder) Size() uint64 {
 	return uint64(c.buf.Len())
 }
 

documentcoder_test.go

@@ -52,7 +52,6 @@ func TestChunkedDocumentCoder(t *testing.T) {
 				t.Fatalf("error adding to documentcoder: %v", err)
 			}
 		}
-		_ = cic.Close()
 		err := cic.Write()
 		if err != nil {
 			t.Fatalf("error writing: %v", err)
@@ -103,8 +102,6 @@ func TestChunkedDocumentCoders(t *testing.T) {
 			t.Fatalf("error adding to documentcoder: %v", err)
 		}
 	}
-	_ = cic1.Close()
-	_ = cic2.Close()
 
 	err := cic1.Write()
 	if err != nil {

merge.go

@@ -682,9 +682,6 @@ func mergeStoredAndRemap(segments []*Segment, drops []*roaring.Bitmap,
 	}
 
 	// document chunk coder
-	if err := docChunkCoder.Close(); err != nil {
-		return 0, nil, err
-	}
 	if err := docChunkCoder.Write(); err != nil {
 		return 0, nil, err
 	}
@@ -749,7 +746,7 @@ func mergeStoredAndRemapSegment(seg *Segment, dropsI *roaring.Bitmap, segNewDocN
 		metaBytes := metaBuf.Bytes()
 
 		// record where we're about to start writing
-		docNumOffsets[newDocNum] = docChunkCoder.BufferSize()
+		docNumOffsets[newDocNum] = docChunkCoder.Size()
 		// document chunk line
 		if _, err := docChunkCoder.Add(newDocNum, metaBytes, data); err != nil {
 			return 0, err
@@ -795,7 +792,7 @@ func (s *Segment) copyStoredDocs(newDocNum uint64, newDocNumOffsets []uint64, do
 			dataLenData := uncompressed[storedOffset+n : storedOffset+n+int(binary.MaxVarintLen64)]
 			dataLen, read := binary.Uvarint(dataLenData)
 			n += read
-			newDocNumOffsets[newDocNum] = docChunkCoder.BufferSize()
+			newDocNumOffsets[newDocNum] = docChunkCoder.Size()
 			metaBytes := uncompressed[storedOffset+n : storedOffset+n+int(metaLen)]
 			data := uncompressed[storedOffset+n+int(metaLen) : storedOffset+n+int(metaLen)+int(dataLen)]
 			if _, err := docChunkCoder.Add(newDocNum, metaBytes, data); err != nil {

new.go

@@ -609,18 +609,14 @@ func (s *interim) writeStoredFields() (
 		}
 
 		metaBytes := s.metaBuf.Bytes()
-		docStoredOffsets[docNum] = docChunkCoder.BufferSize()
+		docStoredOffsets[docNum] = docChunkCoder.Size()
 		_, err = docChunkCoder.Add(uint64(docNum), metaBytes, data)
 		if err != nil {
 			return 0, err
 		}
 	}
 
 	// document chunk coder
-	err = docChunkCoder.Close()
-	if err != nil {
-		return 0, err
-	}
 	err = docChunkCoder.Write()
 	if err != nil {
 		return 0, err