Remove code duplication for regex handling in lobster-cpp
#317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiwuu
added
the
internal
phiwuu
force-pushed
the
internal/cpp-cleanup
branch
15 times, most recently
from
8c025b1 to
317b230
Compare
The code part that matches the output lines from clang tidy against regex contained code duplications. These parts have been moved into a separate helper class to increase the maintainability of the code. This is a pure refactoring without change of functionality, but adds unit tests.
phiwuu
force-pushed
the
internal/cpp-cleanup
branch
from
317b230 to
ed47f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code part that matches the output lines from clang tidy against regex contained code duplications. These parts have been moved into a separate helper class to increase the maintainability of the code.
This is a pure refactoring without change of functionality, but adds unit tests.