detects multi string first instead of normal string, Nested_Lexer#130
Merged
phiwuu merged 3 commits intobmw-software-engineering:mainfrom Mar 27, 2025
Conversation
christophkloeffel
force-pushed
the
patch/multiline_markup_string_assertion_error
branch
from
fc355de to
5bcb726
Compare
christophkloeffel
changed the title
phiwuu
previously approved these changes
Mar 12, 2025
Member
|
@christophkloeffel I have approved the pull request, but unfortunately you need to to a rebase first before GitHub can merge it. |
christophkloeffel
force-pushed
the
patch/multiline_markup_string_assertion_error
branch
from
252bc6d to
c693a67
Compare
phiwuu
approved these changes
Mar 18, 2025
Member
|
@christophkloeffel, there are some merge conflicts. Could you please have a look? Thanks! |
christophkloeffel
force-pushed
the
patch/multiline_markup_string_assertion_error
branch
from
addabcd to
74bd4e0
Compare
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understood it correctly, it would make more sense to first detect the multi string.
The
startswith('"')method used before does also detect a multi string as normal.Basically the triple double quoted string version was not taken into account, so it had to be adapted to that.
fixes #129