Always print statistics #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiwuu
force-pushed
the
feature/always-summary
branch
2 times, most recently
from
fbc0794 to
5397a01
Compare
phiwuu
force-pushed
the
feature/always-summary
branch
3 times, most recently
from
e8d0087 to
fd4b0fe
Compare
The statistics numbers are always printed, regardless of the command line argument `--brief`. That is, the tool always prints a message like this at the end: `Processed 1 model and 1 requirement file and found no issues` When admins integrate TRLC as a voting job into their CI they want to get feedback if the tool finished without sudden termination (possibly caused by the CI system).
phiwuu
force-pushed
the
feature/always-summary
branch
from
fd4b0fe to
53e9d70
Compare
| if mh.suppressed: # pragma: no cover | ||
| summary += " with %u supressed messages" % mh.suppressed | ||
|
|
||
| print(summary) |
There was a problem hiding this comment.
Should this print statement be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statistics numbers are always printed,
regardless of the command line argument
--brief.That is, the tool always prints a message like this at the end:
Processed 1 model and 1 requirement file and found no issuesWhen admins integrate TRLC as a voting job into their CI they want
to get feedback if the tool finished without sudden termination
(possibly caused by the CI system).