-generate – Allow class path to come from file system #6466
+51
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: github-actions <[email protected]> Signed-off-by: github-actions <[email protected]>
pkriens
changed the title
chrisrueger
changed the title
|
I closed this because I solved the problem in another way. Instead of referring to a file with However, this is very useful but I just don't have the time to finish this off. A key missing feature is also to capture the output of the command, at least stderr, and show it on the errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code from source code generation required the bundle to be part of the repositories, it did not support 'version=file'. This was added. If this throws an exception, we fall back to the old way.
Basic change is that we now use the Project's getBundles to get the class path while we use Workspace.getBundle. The Workspace was used since this could also be used in bndrun files but a bndrun file is also a Project ... The Project.getBundles probably belongs on Workspace ...
Signed-off-by: github-actions [email protected]