WIP Upgrade bndtools to Eclipse 4.34 2024-12 #6536
Conversation
chrisrueger
force-pushed
the
upgrade-bndtools-to-higher-eclipse
branch
from
25c88e9 to
416d184
Compare
instead of handcrafted at https://bndtools.jfrog.io/bndtools/bnd-build/eclipse/4.25/index.xml.gz This could make it easier to test and use newer Eclipse Versions, since we start having more and more bugs only happening in newer Eclipse versions. Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
note: version difference is on purpose (the asm:9.2 and the rest of asm.* 9.3). 9.2 is required by org.parboiled:parboiled-java:1.4.1 ) Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
which is smaller, but requires a few other repositories (emf,jgit,m2e,wst) to be able to resolve the .bndrun files Signed-off-by: Christoph Rueger <[email protected]>
Still some startup issues m2e, but bndtools starts Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
upgrade-bndtools-to-higher-eclipse
branch
from
416d184 to
b52bf27
Compare
Note: for windows and linux I had to remove some requirements, since I guess the bundles do not exist anymore. I noticed via Repository Explorer they are disappearing around 2024-03 Signed-off-by: Christoph Rueger <[email protected]> upgrade to Eclipse 4.35 (2025-03) - resolve all .bndruns - fixed some compilation problems because of stuff which was removed from Eclipse 4.35 Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
upgrade-bndtools-to-higher-eclipse
branch
from
b52bf27 to
b0f4f74
Compare
chrisrueger
changed the title
it took me hours to find the reason for the error which was that the BSN changed from org.slf4j.api (in slf4j 1.7.3 which was part of Eclipse 4.25) to slf4j.api ( slf4j 1.7.25 which is in central.maven but not part of eclipse 4.34 anymore)
java.lang.IllegalArgumentException
at org.eclipse.equinox.internal.provisional.p2.core.VersionParser.parseInto(VersionParser.java:71)
Signed-off-by: Christoph Rueger <[email protected]>
TODO still getting build errors (Task :bndtools.core.test:testOSGi FAILED) bndtools.core.test.editors.quickfix.BuildpathQuickFixProcessor_WithEmptyBuildpath_Test <<< ERROR: Cannot invoke "org.osgi.framework.BundleContext.getBundles()" because "bc" is null May related to the jupiter and junit versions which I downgraded to make it resolve. May have to adjust again. Signed-off-by: Christoph Rueger <[email protected]>
because Eclipse 4.34 requires Java 21 minimum Signed-off-by: Christoph Rueger <[email protected]>
this finally fixed bndtools.core.test for me. resolved all test .bndruns again Signed-off-by: Christoph Rueger <[email protected]>
hopefully fixes build / test errors like java.lang.NoClassDefFoundError: org/bouncycastle/asn1/misc/MiscObjectIdentifiers Signed-off-by: Christoph Rueger <[email protected]>
try to fix Exception java.lang.NoClassDefFoundError: org/bouncycastle/asn1/misc/MiscObjectIdentifiers in biz.aQute.bndlib.comm.tests:test Signed-off-by: Christoph Rueger <[email protected]>
to fix HttpTestServerTest Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
|
Current status:
|
Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
versions, versions, versions, versions.... especially since Eclipse repo now has higher versions which causes trouble e.g. slf4j.api 2.0 , hamcrest.... so lots of places where we said version=latest did not work anymore, because in the past that has been 'our' version, but now latest is Eclipse version is is often incompatible Signed-off-by: Christoph Rueger <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
TODO still fail: aQute.tester.junit.platform.test.ActivatorJUnitPlatformTest Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
|
@kriegfrj You seem to be very familiar with all the JUnit Testcases stuff in bnd / bndtools. Some tests are working, but I got there via trial and error and I always feel I'm not doing it right. So I could need some support there. Thanks |
| poll.time=-1;\ | ||
| cache="${workspace}/cnf/cache/stable/Eclipse-4.25" | ||
| aQute.bnd.repository.p2.provider.P2Repository; \ | ||
| url = https://download.eclipse.org/releases/2024-12/; \ |
There was a problem hiding this comment.
Instead of larger upgrades, I would recommend to first go from
2022-09 > 2022-12
using smaller increments (that can then already be merged) usually works better for plugins quite tightly integrated (like Bndtools)
Sorry, I have a lot going on and haven't been paying close attention to this recently. I'm a bit rusty on the details, but I remember that these tests were a bit of a pain because they run inside an Eclipse instance which might have different JUnit on its classpath than the one you are trying to test against. Then the launchpad would include a version of JUnit in the framework-under-test that it launched, which might be different to both of those. The error: ...seems to suggest that this is in that category. It seems that UniqueIdTrackingListener being run inside the launchpad framework is linked to a different version of the TestExecutionListener class. I'll see if I can have a look in the next day or so. |
3 participants
Trying with 2024-12 and/or 2025-03