-
-
Notifications
You must be signed in to change notification settings - Fork 305
Support building bnd with maven via Eclipse tycho #6814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@reckart Could you have a look if that makes life easier for you? |
|
Eclipse detects the projects when I do "import existing maven projects" However, after the import, I have 62379 errors. The projects contain Eclipse metadata files ( When I expand a module to have a look at the dependency tree in the POM, I don't see a The Maven Dependencies container that should contain the project's resolved dependencies is missing from most modules. When I mark the modules and try to right-click and Maven -> Update project..., I get more errors. |
|
I think this approach is ok for adapting the build to CI systems where (for some reason) one would CI using Maven instead of Gradle, but for a local dev setup, it seems not well suited. |
You are probably right. We are using this approach indeed in our own build. I am experimenting a bit more with this PR here to see if I can get it to build, but maybe I won't merge it yet. But do I understand you correctly, that you have trouble setting up Eclipse for bndtools development / contribution? I think you need to use "Import Existing Projects into Workspace": https://github.com/bndtools/bnd/blob/master/CONTRIBUTING.md#importing-into-eclipse Otherwise: Have you tried the Oomph setups? https://bndtools.org/bndtools.p2.repo/ |
This adds support building bnd with Eclipse Tycho 4.0.13 See https://tycho.eclipseprojects.io/doc/4.0.13/BndBuild.html e.g. build inside the repo root with: `mvn clean verify` Signed-off-by: Christoph Rueger <[email protected]>
mvn clean verify -fae -fae needed.to skip a current error in org.bndtools.p2 which will go away soon after PR 6808 Signed-off-by: Christoph Rueger <[email protected]>
we needed to rename /pom.xml to old_pom.xml because otherwise it will conflict / confuse tycho Signed-off-by: Christoph Rueger <[email protected]>
to fix `JAXP00010003: The length of entity "[xml]" is "100,001" that exceeds the "100,000" limit set by "jdk.xml.maxGeneralEntitySizeLimit"` Signed-off-by: Christoph Rueger <[email protected]>
Signed-off-by: Christoph Rueger <[email protected]>
this ensures that tycho is only used when building in root with `mvn clean verify` but not when building with `mvn -f maven-plugins/pom.xml` adjust CI build scripts to call `mvn -f maven-plugins/pom.xml` Signed-off-by: Christoph Rueger <[email protected]>
495efde to
e66b454
Compare
|
The build almost passes locally, but fails with the bundle So expect that this passes once |

This adds support building bnd with maven via Eclipse Tycho 4.0.13 See https://tycho.eclipseprojects.io/doc/4.0.13/BndBuild.html
While the gradle build is still the official way of building bnd, this could serve as an alternative for contributors which are more familiar with Maven.
Example
e.g. build inside the repo root with:
mvn clean verifyor
mvn clean verify -fae(to skip a current error inorg.bndtools.p2which will go away after #6808 has been merged to master)