Fix inheriting default column options #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokonski
force-pushed
the
fix-options-inheritance
branch
from
1b6d7b3 to
6172bea
Compare
pokonski
force-pushed
the
fix-options-inheritance
branch
from
a93f184 to
998f931
Compare
|
@bogdan hello! Is it possible to release a stable version to rubygems with this fix? |
|
v2.0.3. Enjoy. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression caused by #333 in https://github.com/bogdan/datagrid/pull/333/files#diff-e862b050fb30334bd970ac6714786a6120a21c965b4a95f3f57b3f4792adafaeR382.
Merging the default options was moved into the initializer, but it still used the raw argument
optionsinstead of@options. Ruby chose the locally scopedoptionsfrom arguments instead of the attribute reader.Solved by renaming the argument to avoid ambiguity