Update initial submachines of composite states upon re-entry #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a composite state is re-entered due to an event any submachines within the state also need to be initialized, or they will remain in their previous terminated state. - Recursively call update_composite_state on any initial states that are themselves composite - Add a test for this situation
jefftrull
force-pushed
the
bugfix/reenter-composite-state
branch
from
6b1db93 to
20cd435
Compare
This was referenced Oct 13, 2025
Entering a previously visited composite of a compisite state re-enters its last active substate
#495
Open
|
Very nice! Tested this change on our codebase. It seems to fix the reported issue and didn't introduce any regressions for us (we have over 1000 tests cases) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Issue: #645
Reviewers:
@kris-jusiak @deoliveiravinicius