chore: change point_type to point_type_t and use 'using' at those places #1331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
typename point_type<X>::type
topoint_type_t<X>
using
i/otypedef
using
coordinate_type_t
there (but that is not consistently)I also verified
clang-tidy
with its usagemodernize-use-using
but that is not giving the desired results at this moment.Clang tidy can, with its option
modernize-use-using
, replacetypedef
with `using. It sometimes works well, but:typedef differential_quantities<CT, EnableReducedLength, EnableGeodesicScale, 1> quantities
withusing quantities = int
which is plainly wrongtypedef typename boost::range_value<Range const>::type point_t
withusing point_t = typename boost::range_value<const Range>::type
which moves the const to left, and that is not what is in our conventionsTherefore I decided to not use it. So this commit changes to
point_type_t
, plususing
. A next might change tocoordinate_type_t
plususing
and then we can change the rest manually, or semi-automatically (still using clang-tidy but judge per change)