Fix/issue #1326 and #1226 #1341
Open
+172
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
force-pushed
the
fix/issue-1326-and-1226
branch
2 times, most recently
from
7824944
to
c4b7e4d
Compare
barendgehrels
commented
Nov 14, 2024
| TurnBySegmentMap const& start_turns_by_segment, | ||
| Geometry0 const& geometry0, | ||
| Geometry1 const& geometry1) | ||
| { |
There was a problem hiding this comment.
This function is not new, but it is extracted from the original method below
barendgehrels
commented
Nov 14, 2024
| void discard_touch_touch_interior_turns(Turns& turns, | ||
| Geometry0 const& geometry0, | ||
| Geometry1 const& geometry1) | ||
| { |
There was a problem hiding this comment.
This is the fix
This can occur in a sequence of touch and then touch_interior
barendgehrels
force-pushed
the
fix/issue-1326-and-1226
branch
from
c4b7e4d
to
414c464
Compare
barendgehrels
commented
Nov 14, 2024
| @@ -19,6 +19,20 @@ | |||
|
|
|||
| [section:release_notes Release Notes] | |||
|
|
|||
| [/=================] | |||
| [heading Boost 1.87] | |||
| [/=================] | |||
There was a problem hiding this comment.
If it does not make it in 1.87, we'll update
barendgehrels
commented
Nov 14, 2024
| ut_settings settings; | ||
| settings.set_test_validity(false); | ||
| settings.validity_of_sym = false; | ||
| TEST_DIFFERENCE_WITH(issue_1226, 1, 0.238037722, 0, 0.0, 1, settings); |
There was a problem hiding this comment.
Somehow they are reported as invalid.
While (I test in overlay.cpp) in the original test code, they were valid.
I don't know the reason, it might be a false negative or a ccw issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could occur in a sequence of touch and then touch_interior.
This PR fixes #1226 and #1326