Fix constexpr cmath floor of 1 returning 0 #1232#1233
Merged
mborland merged 1 commit intoboostorg:developfrom Jan 13, 2025
Merged
Fix constexpr cmath floor of 1 returning 0 #1232#1233mborland merged 1 commit intoboostorg:developfrom
mborland merged 1 commit intoboostorg:developfrom
Conversation
Member
|
Thanks for pressing on with this. I just approved this workflow run. We must approve workflow runs for first-time contributions @yousseflakhal. Let's let this thing run through CI now. Cc: @mborland and @jzmaddock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
boost::math::ccmath::floorfunction incorrectly returns0.0for1.0in aconstexprcontext.Solution
1.0.ccmath_floor_test.cpp.Linked Issue
Fixes #1232