Skip to content

Fix CI deprecations #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix CI deprecations #1272

wants to merge 4 commits into from

Conversation

mborland
Copy link
Member

Windows-2019 and Ubuntu-22.04 are deprecated in Github Actions, pending removal at the end of the month. Move runs that we can to Drone.

@mborland
Copy link
Member Author

@jzmaddock Have you had any issues with GCC 12 locally? It's strange that Windows GCC is failing the thread sanity check test after updating from 2019 to 2022 OS versions.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (2b05d87) to head (6c8f87f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1272   +/-   ##
========================================
  Coverage    95.07%   95.07%           
========================================
  Files          792      792           
  Lines        66882    66882           
========================================
  Hits         63589    63589           
  Misses        3293     3293           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b05d87...6c8f87f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland
Copy link
Member Author

Yeah GCC 12 and 14 both seem to be showing the MinGW thread_local destruction problem that I thought had been fixed

@mborland mborland closed this Jun 10, 2025
@mborland
Copy link
Member Author

Rolled into #1271

@jzmaddock
Copy link
Collaborator

Have you had any issues with GCC 12 locally? It's strange that Windows GCC is failing the thread sanity check test after updating from 2019 to 2022 OS versions.

Fails for me with cygwin gcc-11, passes with mingw gcc-13 and 14 (I don't have 12 installed at present).

But.... there are multiple mingw builds with different object and threading models :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants