Skip to content

Adjust CircleCI setup to account for Boost.Inspect build change. #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

grafikrobot
Copy link
Member

In addition to changing how to build the inspect tool this change Also simplifies the build and test to avoid future config problems as it can more easily adjust to future CI changes. It bumps the docker image to what the current stable image is to auto-adjust to recent stable gcc compiler.

In addition to changing how to build the inspect tool this change Also simplifies the build and test to avoid future config problems as it can more easily adjust to future CI changes. It bumps the docker image to what the current stable image is to auto-adjust to recent stable gcc compiler.
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (9de48c7) to head (9659c15).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #687   +/-   ##
=======================================
  Coverage     94.1%   94.1%           
=======================================
  Files          280     280           
  Lines        29074   29074           
=======================================
  Hits         27349   27349           
  Misses        1725    1725           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de48c7...9659c15. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jzmaddock
Copy link
Collaborator

Quickbook builds fine for me with gcc-13, so I'm not sure why it would be doing that.

@jzmaddock
Copy link
Collaborator

This fix to Config gets it: boostorg/config#517

Note that the point of the original comment, was that moving the dist-bin target to a different directory is a breaking change that breaks several libraries CI builds.

@grafikrobot grafikrobot closed this May 8, 2025
@grafikrobot grafikrobot reopened this May 8, 2025
@grafikrobot
Copy link
Member Author

@jzmaddock can you rerun the circleci test? As it doesn't rerun on close/reopen.

@jzmaddock
Copy link
Collaborator

@grafikrobot : still seems to fail with the strange internal compiler errors :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants