Boost 1.88 update #464
Merged
Boost 1.88 update #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Github Actions CI Containerize old compiler jobs Fix Node20 Glibc Reformat job list to make it easier to update * Fix install of packages * Remove macos-12
thanks @NVCherney for bring this to my attention.
Closes #440.
…e ends `process_stdio` holds on to the handles for `in`/`out`/`err`. In case of pipes, `in` needs the handles of a `readable_pipe`, whereas `out` and `err` need the handles of `writable_pipe`s. So far, the tests all create a new pair using `connect_pipe`, pass the "correct" end into `process_stdio`, and use the other end to interface with the process. However, `process_io_binding` also supports construction from the complementary pipe types, i.e., constructing `in`'s binding from a `writable_pipe` and `out`/`err`'s bindings from `readable_pipe`s. In this case, the constructor will create the corresponding pipe itself and keep ownership of it. This mode was thus far not tested.
This test currently fails on POSIX, as `process_io_binding` does not explicitly implement move operations but holds on to a file descriptor which exhibits reference semantics and has a non-trivial destructor. The same test should pass on Windows as the Windows implementation makes use of `unique_ptr` which gives it correct move semantics by virtue of the rule of zero.
…erations This makes the test added in the previous commit pass.
As of 2ccd97c, v2 is the default when using the unversioned includes. This broke the v1 tests which were still using those.
Build previously failed when BOOST_PROCESS_USE_STD_FS was ON, because filesystem was linked to regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.