reboot: Quiet the output from systemd-run #1450
Conversation
The fact that we have a transient unit here is just implementation detail, no need to tell the user the name of the unit.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to quiet the output from systemd-run when rebooting the system. The change is correct and achieves this by adding the --quiet flag. My review includes a suggestion to use the existing Task::quiet_output() helper method, which provides a more idiomatic way to achieve the same result within this project's architecture. This improves maintainability by consistently using the provided abstractions for command execution.
|
OK looks like Testing Farm is having issues according to https://status.testing-farm.io/ ... |
|
Hmm I think I'm also going to drop the rawhide tests by default, we shouldn't be gating PRs on that. Also, it's not clear to me we need to run e2e tests on every PR on both x86_64 and aarch64 across supported platforms by default. If for example we get green on say centos-stream-10-aarch64, the chance that centos-stream-10-x86_64 is currently really low (apart from any code touching bootloader things). |
2 participants
The fact that we have a transient unit here is just implementation detail, no need to tell the user the name of the unit.