ostree-ext: Replace config loading with a stub if we detect mock#1695
Closed
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Closed
ostree-ext: Replace config loading with a stub if we detect mock#1695cgwalters wants to merge 1 commit intobootc-dev:mainfrom
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround to skip loading the global authentication file when running within a mock build environment, which is a sensible approach to avoid errors in that context. My main feedback is that this workaround is conditionally compiled for test builds only. This might not cover all use cases, such as release builds within mock, potentially leaving the original issue unresolved in those scenarios. I've recommended making the workaround unconditional.
cgwalters
force-pushed
the
copr-workaround
branch
3 times, most recently
from
c41e37b to
deb6870
Compare
Workaround for rpm-software-management/mock#1613 (comment) Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
copr-workaround
branch
from
deb6870 to
5cfbed3
Compare
Collaborator
Author
|
Just going to fold this into #1693 - no point having two PRs |
auto-merge was automatically disabled
October 21, 2025 12:34
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for rpm-software-management/mock#1613 (comment)