Move blockdev code from bootupd into blockdev crate#2042
Open
ckyrouac wants to merge 2 commits intobootc-dev:mainfrom
Open
Move blockdev code from bootupd into blockdev crate#2042ckyrouac wants to merge 2 commits intobootc-dev:mainfrom
ckyrouac wants to merge 2 commits intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors block device handling logic into a dedicated blockdev crate, which is a good step towards better code organization and prepares for future multi-device support. The changes primarily involve moving code and renaming functions for improved clarity. My review includes a couple of suggestions to make newly added functions more concise and idiomatic by leveraging Rust's iterator capabilities.
ckyrouac
force-pushed
the
blockdev-migration
branch
from
d04faa0 to
9ff49ee
Compare
ckyrouac
force-pushed
the
blockdev-migration
branch
from
9ff49ee to
ad0b88c
Compare
cgwalters
reviewed
Mar 4, 2026
Migrating all the blockdev code that is in bootupd into the blockdev crate to simplify its usage and keep it colocated. Signed-off-by: ckyrouac <[email protected]>
This is prep for supporting multiple parent devices. Assisted-by: Claude Code (Opus 4) Signed-off-by: ckyrouac <[email protected]>
ckyrouac
force-pushed
the
blockdev-migration
branch
from
ad0b88c to
01280ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidating the blockdev code that was scattered across bootupd and bootc into the blockdev crate. This is prep and cleanup for multi device parent support in bootupd. This needs to be merged before the bootupd changes can be merged. Then, after the multi device support changes to bootupd are merged, I'll open another PR against bootc to integrate with the multi device bootupd changes.