[Do not merge] Add static build in the ci with workarounds#2272
Closed
talregev wants to merge 5 commits intoborglab:developfrom
Closed
[Do not merge] Add static build in the ci with workarounds#2272talregev wants to merge 5 commits intoborglab:developfrom
talregev wants to merge 5 commits intoborglab:developfrom
Conversation
Contributor
Author
|
Compilation errors that PR solve: |
Contributor
Author
|
divided by zero error that can be solve in other PR: |
Contributor
|
I shipped my full cephes fix in #2273. It was more than just fixing the C math functions, but also symbol exports (and I have a preference for making the build system handle that). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add static build in the ci with workarounds.
I take the workarounds of @Gold856 in this commit: Gold856@6c530ef
and combine them with mine and create this PR.
I manage to compile static build without permissive flag that suggested in this PR: #2268
On static release build, the build fail on divided by zero that detected in the compilation time.
I can change the code, but it change the behavior of the function. In the new behavior tests are failing.
I can add a seperate PR for it, and we can discuss it there.
This PR is not meant to merge, because it solve the compilation problem with workarounds. The PR highlight the problems and people can take this PR and solve them in the correct way.
Some of the changes are good in my perspective, and I can make a PR for those changes. For example: Add the ability to compile cephes in static build.