Don't listen for message echoes. Fixes #22

botman · Sep 9, 2017 · 0ffee2b · 0ffee2b
1 parent d12326b
commit 0ffee2b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/FacebookDriver.php b/src/FacebookDriver.php
@@ -83,7 +83,7 @@ public function matchesRequest()
     {
         $validSignature = empty($this->config->get('app_secret')) || $this->validateSignature();
         $messages = Collection::make($this->event->get('messaging'))->filter(function ($msg) {
-            return isset($msg['message']['text']) || isset($msg['postback']['payload']);
+            return (isset($msg['message']['text']) || isset($msg['postback']['payload'])) && !isset($msg['message']['is_echo']);
         });
 
         return ! $messages->isEmpty() && $validSignature;

diff --git a/tests/FacebookDriverTest.php b/tests/FacebookDriverTest.php
@@ -74,6 +74,10 @@ public function it_matches_the_request()
         $driver = $this->getDriver($request);
         $this->assertTrue($driver->matchesRequest());
 
+        $request = '{"object":"page","entry":[{"id":"111899832631525","time":1480279487271,"messaging":[{"sender":{"id":"1433960459967306"},"recipient":{"id":"111899832631525"},"timestamp":1480279487147,"message":{"is_echo":true,"mid":"mid.1480279487147:4388d3b344","seq":36,"text":"Hi"}}]}]}';
+        $driver = $this->getDriver($request);
+        $this->assertFalse($driver->matchesRequest());
+
         $config = [
             'facebook' => [
                 'token' => 'Foo',