Skip to content

Conversation

@ubaskota
Copy link
Contributor

@ubaskota ubaskota commented Oct 15, 2025

This PR reverts the previously reverted PR and updates the functional tests to provide only one credential provider in a credential resolver.

Description:
In the reverted PR, we initially mocked the functional tests using get_credentials to return a list containing only one credential. This resulted in a list where the specified credential was included, but None values were returned for other credential providers. While this worked as expected in local environments, it could cause issues when lower-precedence credential providers are available.

To address this, the PR now mocks the create_credential_resolver function instead, returning a list that contains only the intended credential provider.

Tests:
I verified that the functional tests related to registering credential feature ids run successfully.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (8121342) to head (63fc87e).
⚠️ Report is 9 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3580   +/-   ##
========================================
  Coverage    93.17%   93.17%           
========================================
  Files           68       68           
  Lines        15411    15411           
========================================
  Hits         14359    14359           
  Misses        1052     1052           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SamRemis SamRemis changed the title Revert a reverted commmit and update functional tests. Refactor mocking of credentials resolvers for user agent tests Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants