added Tagging and TaggingDirective to ALLOWED_UPLOAD_ARGS #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please pull the MR, I have been waiting 16 days now ^^ :) |
|
I approve of this. Please make it happen asap. I don't want to upload an object and THEN add a tag.. |
|
+1 |
|
Any update on this? Would love to see this get merged |
|
@rvrangel Thanks for the pull request and sorry about the delay here! I looked over the PR and it looked good. There was an edge case that needed to be added related to filtering out |
|
Thanks @kyleknap, really appreciate it 🙇 |
|
Is there any update to this Open PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #94 and PR #96
Looks like that PR hasn't been updated in more than a year, so I am creating a new one to add Tagging and TaggingDirective to
S3Transferand also including the change on__init__.py.