Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate potential race conditions while rebooting #631

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Eliminate potential race conditions while rebooting #631

merged 4 commits into from
Jun 26, 2024

Commits on Jun 25, 2024

  1. update deny.toml to version 2 

    Several keys have been deprecated in favor of the same default values we
were specifying before. By removing them and adding `version = 2` under
licenses, we will maintain the same behavior but without the deprecation
notices that we being printed.
    @cbgbt
    cbgbt committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e6b384a View commit details
    Browse the repository at this point in the history

  2. Update dependencies with cargo update

    @cbgbt
    cbgbt committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a9202f3 View commit details
    Browse the repository at this point in the history

  3. update bottlerocket sdk to 0.42.0

    @cbgbt
    cbgbt committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6d16aac View commit details
    Browse the repository at this point in the history

  4. agent: eliminate potential races while rebooting 

    The agent had a few conditions under which it can enter the
MonitoringUpdate state before it successfully uncordons the node:

* Brupop updates its state into Rebooted before the reboot terminates
  the process
* After rebooting, an error ocurrs after updating the state but before
  performing the uncordon.

We avoid this conditions by:
* Exiting the agent process in cases where the desired state is Rebooted
  but we are not yet running the new version.
* Always uncordoning the node before marking that we have successfully
  transitioned into the Rebooted state.
* Defensively uncordoning the node once again when we enter the
  Monitoring state.
    @cbgbt
    cbgbt committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    73aae1b View commit details
    Browse the repository at this point in the history