Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow brupop-controller-deployment pods to be discovered by Splunk otel-collector #677

Conversation

AndreiBanaruTakeda
Copy link
Contributor

Issue number:
#676

Description of changes:
Ensured deployment/brupop-controller-deployment is annotated for Splunk otel-collector to discover its pods:

spec:
  template:
    metadata:
      annotations:
        prometheus.io/port: "8080"
        prometheus.io/scrape: "true"

Testing done:

  1. I manually edited deploy/brupop-controller-deployment and added the above annotations
  2. kubectl rollout restart deployment brupop-controller-deployment
  3. I had to wait for the scheduler_cron_expression for metrics to become available
  4. Checked for the metrics in Splunk

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@ytsssun ytsssun merged commit 5c664ff into bottlerocket-os:develop Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants