fix: improve status code extraction from API client error messages #781
Conversation
agent/src/apiclient.rs
Outdated
| fn extract_status_code_from_error(error: &str) -> &str { | ||
| let error_content_split_by_status: Vec<&str> = error.split("Status").collect(); | ||
| let error_content_split_by_whitespace: Vec<&str> = error_content_split_by_status[1] | ||
| fn extract_status_code_from_error(error: &str) -> Option<StatusCode> { |
There was a problem hiding this comment.
I wonder if there is a more direct way of getting that status code such as directly use the unix socket and invoke the APIServer using an http client.
Having to parse the status code from the response feels a bit odd to me..
There was a problem hiding this comment.
We shouldn't directly use the unix socket. The intended architectural approach is to utilize the existing apiclient binary rather than creating a custom HTTP client to communicate directly with the Bottlerocket API. If we do want this functionality, the change would take place in the apiclient rather than within Brupop, and would be tied to the newer Bottlerocket releases. Since the API client would return the response rather than just the code, we would need to parse the response for the code.
|
I was not able to reproduce the original issue since there was a custom build involved, but I was able to include unit tests to mock the scenario experienced in the original issue to validate that the fix works. |
Bug fix for index-out-of-bounds error when attempting to parse the status message string for status code and the delimiter "Status" is not found. extract_status_code_from_error returns None if the delimiter is not found or an invalid status code is given in the error message
Add error handling messages for status code parsing Add unit tests to validate changes
maherthomsi
force-pushed
the
index_out_of_bounds_fix
branch
from
36ba027 to
608721f
Compare
|
Commit message changes |
Issue number:
#774
Description of changes:
Fix a bug where an index out-of-bounds error would be returned when "Status" is not in the apiclient response error message. The previous string-based approach using "Status" as a delimiter could fail if the delimiter was not present or formatted differently.
This change replaces string manipulation with proper HTTP status code parsing using the http crate's StatusCode type. The extraction now safely handles missing delimiters and invalid status codes by returning the StatusCode instead of raw string slices.
Testing done:
Ran
make buildValidated status code parsing function locally.
Created unit tests for status code parsing function
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.