krane: update ecr-login to v0.11.0 #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparksssj
approved these changes
Nov 10, 2025
jmt-lab
approved these changes
Nov 10, 2025
7 tasks
Signed-off-by: Sam Berning <[email protected]>
sam-berning
force-pushed
the
patch-krane-cred-helper
branch
from
c8d84a7 to
065153c
Compare
Contributor
Author
|
^ updated to use go-containerregistry from git archives instead of from the release artifacts, which makes many of the changes to |
cbgbt
approved these changes
Nov 10, 2025
Contributor
cbgbt
left a comment
cbgbt
left a comment
There was a problem hiding this comment.
lgtm assuming the build succeeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Update ecr-login to v0.11.0. Also bump the base version of krane to v0.20.6 and drop the unneeded patches, since all of the dependency versions in those patches have now been taken by upstream krane, see: https://github.com/google/go-containerregistry/blob/v0.20.6/cmd/krane/go.mod.
Testing done:
Built twoliter, and ensured that the resulting krane is able to get credentials for EUSC regions using
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.