tools: use latest go version in 'docker-go'#599
Closed
vigh-m wants to merge 1 commit intobottlerocket-os:developfrom
Closed
tools: use latest go version in 'docker-go'#599vigh-m wants to merge 1 commit intobottlerocket-os:developfrom
vigh-m wants to merge 1 commit intobottlerocket-os:developfrom
Conversation
Signed-off-by: Vighnesh Maheshwari <vighmah@amazon.com>
bcressey
approved these changes
Nov 18, 2025
cbgbt
approved these changes
Nov 18, 2025
Contributor
cbgbt
left a comment
There was a problem hiding this comment.
lgtm!
You mentioned offline adding a go-latest to the SDK. Could you cut an issue for that? We'd want one in the twoliter repository to make sure we migrate to that when it happens.
Contributor
Author
|
Yup! Thanks. I've create the two tickets and linked the Twoliter one here. |
Contributor
Author
|
Cancelling in favor of #605 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Find the latest go version available in the sdk and set that as the first option in the path when executing the command in the
docker-goscript.Testing done:
Before this change:
After the change:
% % make -e TWOLITER_ALLOW_SOURCE_INSTALL=false -e TWOLITER_ALLOW_BINARY_INSTALL=false -e TWOLITER_SKIP_VERSION_CHECK=true twoliter fetch go: downloading github.com/containerd/errdefs/pkg v0.3.0 go: downloading github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6 go: downloading cyphar.com/go-pathrs v0.2.1 <--------No failures on this package go: downloading github.com/sasha-s/go-deadlock v0.3.6 go: downloading github.com/petermattis/goid v0.0.0-20250904145737-900bdf8bb490 go: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 go: downloading github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.