Skip to content

tools: use latest go version in 'docker-go'#599

Closed
vigh-m wants to merge 1 commit intobottlerocket-os:developfrom
vigh-m:docker-go-version
Closed

tools: use latest go version in 'docker-go'#599
vigh-m wants to merge 1 commit intobottlerocket-os:developfrom
vigh-m:docker-go-version

Conversation

@vigh-m
Copy link
Contributor

@vigh-m vigh-m commented Nov 18, 2025

Description of changes:
Find the latest go version available in the sdk and set that as the first option in the path when executing the command in the docker-go script.

Testing done:
Before this change:

% make twoliter fetch
.
.
.
go: downloading github.com/sasha-s/go-deadlock v0.3.6
go: downloading github.com/petermattis/goid v0.0.0-20250904145737-900bdf8bb490
go: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2
go: downloading github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8
go: host-ctr/cmd/host-ctr imports
        github.com/containerd/containerd/pkg/cri/server imports
        github.com/opencontainers/selinux/go-selinux imports
        github.com/cyphar/filepath-securejoin/pathrs-lite imports
        cyphar.com/go-pathrs: unrecognized import path "cyphar.com/go-pathrs": parse https://cyphar.com/go-pathrs?go-get=1: no go-import meta tags ()
go: host-ctr/cmd/host-ctr imports
        github.com/containerd/containerd/pkg/cri/server imports
        github.com/opencontainers/selinux/go-selinux imports
        github.com/cyphar/filepath-securejoin/pathrs-lite/procfs imports
        cyphar.com/go-pathrs/procfs: unrecognized import path "cyphar.com/go-pathrs": parse https://cyphar.com/go-pathrs?go-get=1: no go-import meta tags ()
Error while executing command, exit code: 1
Error: Command was unsuccessful, exit code 105
make: *** [Makefile:65: twoliter] Error 1

After the change:

% % make -e TWOLITER_ALLOW_SOURCE_INSTALL=false -e TWOLITER_ALLOW_BINARY_INSTALL=false -e TWOLITER_SKIP_VERSION_CHECK=true twoliter fetch
go: downloading github.com/containerd/errdefs/pkg v0.3.0
go: downloading github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6
go: downloading cyphar.com/go-pathrs v0.2.1 <--------No failures on this package
go: downloading github.com/sasha-s/go-deadlock v0.3.6
go: downloading github.com/petermattis/goid v0.0.0-20250904145737-900bdf8bb490
go: downloading github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2
go: downloading github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Signed-off-by: Vighnesh Maheshwari <vighmah@amazon.com>
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

You mentioned offline adding a go-latest to the SDK. Could you cut an issue for that? We'd want one in the twoliter repository to make sure we migrate to that when it happens.

@vigh-m
Copy link
Contributor Author

vigh-m commented Nov 19, 2025

Yup! Thanks. I've create the two tickets and linked the Twoliter one here.

@vigh-m
Copy link
Contributor Author

vigh-m commented Nov 26, 2025

Cancelling in favor of #605

@vigh-m vigh-m closed this Nov 26, 2025
@vigh-m vigh-m deleted the docker-go-version branch November 26, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants