Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for LaplaceXZPetsc #2359

Draft
wants to merge 6 commits into
base: next
Choose a base branch
from
Draft

Add unit test for LaplaceXZPetsc #2359

wants to merge 6 commits into from

Conversation

dschwoerer
Copy link
Contributor

No description provided.

@dschwoerer dschwoerer mentioned this pull request Jul 1, 2021
Closed
@ZedThree
Copy link
Member

ZedThree commented Jul 1, 2021

See #2207 for some discussion

@ZedThree ZedThree changed the title LaplaceXZ is buggy Add unit test for LaplaceXZPetsc Jul 1, 2021
@ZedThree ZedThree mentioned this pull request Jul 1, 2021
Merged
11 tasks
@ZedThree
Copy link
Member

ZedThree commented Jul 7, 2021

Possible directions for investigation:

  • convergence checks for the round-trip test here: if the issue is one of mismatched discretisations, the error should decrease as we increase the resolution
  • analytic tests: this could be done in both uniform and spatially-dependent metric tensors by solving the forward operator with something like sympy or mathematica -- this would give us analytic tests for both forward and inverse operators

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschwoerer @ZedThree