Add output:flush_frequency for OptionsNetCDF
#2934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appears on include guard instead of class
Avoids rewriting time-independent data, gives slight performance boost
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -229,13 +230,19 @@ void PhysicsModel::writeOutputFile(const Options& options, | |||
| } | |||
|
|
|||
| void PhysicsModel::finishOutputTimestep() const { | |||
| if (output_enabled) { | |||
| Timer timer("io"); | |||
There was a problem hiding this comment.
warning: variable 'timer' of type 'Timer' can be declared 'const' [misc-const-correctness]
Suggested change
| Timer timer("io"); | |
| Timer const timer("io"); |
| @@ -74,7 +76,7 @@ private: | |||
| }; | |||
|
|
|||
| namespace { | |||
| RegisterOptionsIO<OptionsNetCDF> registeroptionsnetcdf("netcdf"); | |||
| const RegisterOptionsIO<OptionsNetCDF> registeroptionsnetcdf("netcdf"); | |||
There was a problem hiding this comment.
warning: variable 'registeroptionsnetcdf' defined in a header file; variable definitions in header files can lead to ODR violations [misc-definitions-in-headers]
const RegisterOptionsIO<OptionsNetCDF> registeroptionsnetcdf("netcdf");
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of fixes #2878
Two things:
output:flush_frequencycan be used to reduce how often netCDF data is flushed to disk (maybeflush_periodis a more accurate name?)Optionsused to store data to be written to disk is now reset after writingThese two together can significantly cut the time spent in IO:
(absolute time from the
iotimer forconductionexample for 500 timesteps, rolling average over 100 steps)The red line is basically current
nextI'm a bit concerned that we still get an increase over time, but this seems to unavoidable.
This PR also includes some drive-by fixes for some minor
OptionsIOissues.