Add isFci also to mesh #3001
Add isFci also to mesh #3001
Conversation
|
Like #2887 for the mesh |
|
@ggeorgakoudis do you mind sharing the logs for the gitlab CI? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
Unfortunately the gitlab CI is behind the LLNL firewall so only LLNL employees have access 🙁. It's not ideal but at least it gives us a way to do GPU run tests. I suppose @bendudson and myself can paste logs as needed. |
| std::shared_ptr<Coordinates> | ||
| getCoordinatesConst(const CELL_LOC location = CELL_CENTRE) const { |
There was a problem hiding this comment.
I think ideally this would be:
| std::shared_ptr<Coordinates> | |
| getCoordinatesConst(const CELL_LOC location = CELL_CENTRE) const { | |
| const Coordinates& | |
| getCoordinates(const CELL_LOC location = CELL_CENTRE) const { |
but maybe this is too likely to cause issues elsewhere
| @@ -828,6 +841,16 @@ public: | |||
| ASSERT1(RegionID.has_value()); | |||
| return region3D[RegionID.value()]; | |||
| } | |||
| bool isFci() const { | |||
No description provided.