-
Notifications
You must be signed in to change notification settings - Fork 2
Make BOUT++ a separate package. #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oparry-ukaea
wants to merge
15
commits into
main
Choose a base branch
from
boutpp-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding the C version of the MPI library.
3 tasks
Contributor
Author
|
N.B. fa6fefc can be reverted if using a version of bout with the changes from boutproject/BOUT-dev#3101 |
…es where possible.
…ffd17bc595900ac269708c008 and on bout/next at bcfde74a43c82771ff2970df980e2e450191778f).
e725b1e to
6430d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a package file for BOUT++ and makes it a dependency of the Hermes-3 package.
Resolves #3.
Resolves #9.
ToDo:
- [ ] Limit PETSc to 3.23 as per bout docs?- [ ] Limit SUNDIALS to 6.7.0 as per bout docs? (Seems to build fine with 7.0, though)- [ ] Add "coverage" variant (conflicts if compiler isn't gcc or clang); defaults to offLeaving PETSc and SUNDIALS versions unrestricted for now.
coverage variant can be added later if necessary.