Refactor H isotope charge exchange to use the new reactions framework. #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mjuelHydIsotopeReaction.
ZedThree
reviewed
Oct 3, 2025
| * @return std::vector<std::string> vector of keys | ||
| */ | ||
| template <typename T> | ||
| static inline std::vector<std::string> str_keys(const std::map<std::string, T>& map) { |
Member
There was a problem hiding this comment.
C++20 has std::views::keys -- not for this PR, but worth thinking if we can move to C++20 @bendudson ?
… functions in Reaction subclasses.
… T ( matches previous HCX implementation).
…names and return single matches.
…diagnostic values in the 1D-recycling int test.
…ssociated with compiler optimisation.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 26.41% 27.44% +1.03%
==========================================
Files 90 89 -1
Lines 8105 8208 +103
Branches 1133 1159 +26
==========================================
+ Hits 2141 2253 +112
+ Misses 5745 5725 -20
- Partials 219 230 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some implementation details:
RateHelperto cope with (Amjuel) fits that are a function of (T), (E,T) and (n,T).RateHelperis templated on the param types, butReactiondecides which to use at runtime. This allows subclasses to (for instance) read the type from a json file.ReactionParseris modified to cope with momentum and energy transfer in symmetric reactions (e.g. h + h+ -> h+ + h)tests/integrated/1D-recycling/runtesthas been modified to significantly tighten up the tolerances as far as possible and regression data is now stored separately depending on the compiler optimisation level (which is extracted from the run output).ToDo: