WIP: FCI changes #407
Open
WIP: FCI changes #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* full_velocity does not work, so is skipped for now.
Co-authored-by: David Bold <[email protected]>
Co-authored-by: David Bold <[email protected]>
Co-authored-by: David Bold <[email protected]>
Co-authored-by: David Bold <[email protected]>
Co-authored-by: David Bold <[email protected]>
- If curvature isn't read, throw an exception rather than silently continuing with no curvature - If using FCI, curvature normalisation needs to be different, because x is dimensionless (rather than a flux).
Need to fill yup/down fields
For FCI simulations T needs yup/ydown fields. When a BoutReal is converted to a Field3D the yup/down fields are not set.
Seem to cause problems with inner boundary: Observe temperature falling to low values from the inner (X) boundary.
Test works for 3D metrics
Diamagnetic drift for FCI + bugfixes
Update BOUT++ in FCI branch
Damp gradients of velocity rather than gradients of momentum.
With FCI, need to communicate and interpolate T in addition to interpolating P and N.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. This PR contains changes for simulations of 3D geometries.