Skip to content

Conversation

@malamast
Copy link

Just a few suggestions for neutral_mixed and other components:

  1. added a functionality to initialize n and p from grid variables.
  2. Changed the way we calculate the flux limiters and transport coefficients of neutrals. I separate the gradients for the flux limiters in parallel and perpendicular directions. They do something similar in uedge as well.
  3. Added the contribution of ion velocities to the neutral perpendicular velocity. This term comes for momentum sources in the derivation of the neutral perpendicular velocity. How can we generalize it here for multiple species?
  4. minor changes to zero_current and braginskii_collisions components.

…er density and pressure from grid variables with names varName_init.

fixed_density and isothermal: Added a functionality to read the fixed denstiy or temperature from grid variables with names varName_init
…mponents. This willbe needed in neutral_mixed for calculating the contribution of the ion velocity.
…perpendicular velocity to make it consistent with AFN models.
…the perpendicular and parallel directions. This is what they do in UEDGE as well.

-Added the contibution of ion velocities to the neural diffusion perpendicular velocity. This term comes form momentum source terms due to collisions of neutrals  with ions. See eq 20 amd 21 of Horsten 2017.
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 20.15504% with 103 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.27%. Comparing base (e0f1ebf) to head (07ea3b3).

Files with missing lines Patch % Lines
src/neutral_mixed.cxx 0.00% 86 Missing ⚠️
src/zero_current.cxx 44.44% 5 Missing ⚠️
include/fixed_density.hxx 50.00% 2 Missing and 1 partial ⚠️
src/evolve_density.cxx 50.00% 2 Missing and 1 partial ⚠️
src/evolve_pressure.cxx 62.50% 2 Missing and 1 partial ⚠️
src/isothermal.cxx 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   26.41%   26.27%   -0.15%     
==========================================
  Files          90       90              
  Lines        8105     8221     +116     
  Branches     1133     1146      +13     
==========================================
+ Hits         2141     2160      +19     
- Misses       5745     5836      +91     
- Partials      219      225       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikekryjak
Copy link
Collaborator

Thanks for this @malamast. My own re-implementation of this (mikekryjak#15) has been hopelessly delayed by several conferences and an unrelated paper. These are now done so I will be moving onto this soon. I need to compare the performance of these limiters against my SOLPS and SOLEDGE2D results. I can also implement some unit tests.

@malamast
Copy link
Author

malamast commented Jan 7, 2026

Thanks for this @malamast. My own re-implementation of this (mikekryjak#15) has been hopelessly delayed by several conferences and an unrelated paper. These are now done so I will be moving onto this soon. I need to compare the performance of these limiters against my SOLPS and SOLEDGE2D results. I can also implement some unit tests.

Hi Mike. Sounds good. Sorry, I hadn't seen your pull request. Maybe we could try to merge the changes in the two PRs together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants