Improvements to grid- and restart-file loading #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is generated by setuptools_scm, so does not need to be tracked by git.
BOUT++ does this, so add it for consistency.
Having an explicit exclude list rather than an include list means that we can still skip variables that are created by xBOUT, but include any scalar variables that a PhysicsModel might have added to restart files. Extra scalar variables in restart files should not (usually at least) do any harm, so the 'exclude' approach should cover more use cases correctly.
Allows using `drop_variables` argument, which is sometimes useful.
These are needed in order to apply geometry to the grid Dataset.
|
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-01-16 20:04:43 UTC |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 75.91% 75.38% -0.54%
==========================================
Files 15 15
Lines 2745 2779 +34
Branches 655 668 +13
==========================================
+ Hits 2084 2095 +11
- Misses 425 442 +17
- Partials 236 242 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #231 because they may be independently useful, so useful to merge before #231 is finished.