Skip to content

Many files no warn #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dschwoerer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Many files no warn #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c0996
Do not unconditionally set file_cache_maxsize
dschwoerer Nov 28, 2025
87d63f3
Do not bother user about opening many files
dschwoerer Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions xbout/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,15 +738,7 @@ def _expand_filepaths(datapath):
if not filepaths:
raise IOError("No datafiles found matching datapath={}".format(datapath))

if len(filepaths) > 128:
warn(
"Trying to open a large number of files - setting xarray's"
" `file_cache_maxsize` global option to {} to accommodate this. "
"Recommend using `xr.set_options(file_cache_maxsize=NUM)`"
" to explicitly set this to a large enough value.".format(
str(len(filepaths))
)
)
if len(filepaths) > xr.get_options().get("file_cache_maxsize", 128):
xr.set_options(file_cache_maxsize=len(filepaths))

return filepaths, filetype
Expand Down
Loading