-
Notifications
You must be signed in to change notification settings - Fork 2
Add decomposition check #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This will need to go into xBOUT.
Renaming j1_1g and adding ny_innerg
ny_innerg makes selecting easier. It's always defined as the index of the outer upper target in double null.
"selectors" are now named "slices" because that's what they do. "selecting" is now only "indexing arrays" and returning arrays or xarray datasets, not slices.
They return a dataset/dataarray that has been indexed according to the poloidal and radial indices of a slice coming from selectors.slice_2d.
More descriptive.
to be added as separate PR
|
Looks useful! Sebastian was looking at adding something like this directly to BOUT++. It might be possible to work some magic to expose that functionality through I think this includes #25 ? Please could you just cherry-pick the relevant commits onto a new branch? |
|
I actually don't know what |
2c1d0e0 to
3ff43c0
Compare
Tells you what core counts work.
|
|
Not on CI yet but works with pytest
This is because we're now downloading zipped grids during tests
|
Added tests on the new test grids. Still no CI though. Ready for review |
Built on top of #25
This PR adds two methods to
HypnotoadGrid:check_decompositionfor several core counts up tomax_procsand returns a list of how what core counts work. If you enableverbose, it will explain why each core count did or did not work.This is based on the work of @bendudson in https://github.com/boutproject/ips-bout/blob/main/ipsbout/bout_worker.py#L89. The main change is that I simplified the structure of the code so it's more readable, and added the verbose descriptions.
This definitely should be in xBOUT, but since it needs
HypnotoadGrid, I propose we move it all wholesale later. Also, since I have now prepared an explanation for each failure case, we should add these to BOUT++ as well so that the errors are more verbose.To do:
Example output: