Added option absolute/relative symlinks#68
Open
ipetrovic11 wants to merge 3 commits intobower:masterfrom
Open
Conversation
Pulling latest changes from original project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes there is a need symlinks to be exactly like they were creating during creation of ZIP file and we don't want symlinks to be absolute always.
I've created option 'absolute' which leaves default behavior by default, but if there is a need someone could pass 'false' and get relative links.
One example where this is needed - decompression of Electron based application update on MacOS. Once we extract .app file we wan't to be able to move it around(Desktop, Applications folder, etc..) and if we have absolute symlinks it won't work. But if we have relative symlinks everything works like a charm.